-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeepVertex and DeepJet+DeepVertex combination in release (onnx inference) #31988
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31988/19471
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31988/19472
|
A new Pull Request was created by @leonardogiannini for master. It involves the following packages: PhysicsTools/PatAlgos @perrotta, @jpata, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
The profiles for cpu and memory of a ReMiniAOD (step2 of 1325.518) |
Thanks for that, but I can't find DeepVertex in the latest profiles. Can you check if it was enabled in step2? |
Comparison is ready Comparison Summary:
|
I suppose it's below 1000. It appears in the timing reports as usual together with the other taggers TimeReport 0.012164 0.012164 0.012164 pfDeepCombinedJetTagsSlimmedDeepFlavour Now the inference is bit more optimized wrt to the PU200 profile, as it runs only on interesting jets and there are less jets overall in these samples. (I am running on /store/relval/CMSSW_10_6_4/RelValProdTTbar_13_pmx25ns/AODSIM/PUpmx25ns_106X_upgrade2018_realistic_v9-v1/10000/*) |
https://legianni.web.cern.ch/legianni/cgi-bin/igprof-navigator/testMINI+bTag/Remini_cpu/17
the "total" for the denominator is close to 35%. I don't see any changes in the TagInfos in this PR, but in the profiler |
I made an additional check with 1000 events, here are the profiles in particular: the TagInfos are not modified, since the modules are not in standard production. However, |
I see, indeed in DeepFlavourTagInfoProducer |
I created #32114 to keep track of the progress to improve the TagInfos code |
+reconstruction
|
We are working on the integration of TF GPU into cmsdist, but we cannot give a reliable timeline yet, so no objects from our side to remove the TF evaluator at this point. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The PR adds the new training of the DeepVertex taggers and the Combination with DeepJet. The BTV POG wants to have them into the release but not in the standard production for future deployment studies.
The BTV group will take care of enabling the taggers for a BTV only dedicated production.
In order to test, expand the configuration RecoBTag/ONNXRuntime/test/test_deep_vertexcomb_cfg.py
and turn to "True" the switches "compute_probabilities" and "run_deepVertex", which are set by default to "False" (module pfDeepFlavourTagInfos). Alternatively, modify RecoBTag/FeatureTools/plugins/DeepFlavourTagInfoProducer.cc before compiling.
PR validation:
the PR is presented here https://docs.google.com/presentation/d/1vWKUH2ANOMQWEdp-tT-9S8WW29RPKoe8m8zNzdk1O6M/edit#slide=id.ga4e5d7cc6d_0_79
After the meeting the agreement was to add taggers with ONNX inference
The performances validated in CMSSW are in slide 3 (purple line)